Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

Thanks! The schema name is also too general: metadata.json will likely yield too many false positives;

Thanks! The schema name is also too general: metadata.json will likely yield too many false positives;

That's true; how would I remove it from being associated with a specific file pattern then?

Also, docker-extension-metadata.json does have a $schema which is set to https://json-schema.org/draft-07/schema#, so I'm not sure why it's failing here

@KTrain5169 We allow for fileMatch to be empty array or not defined at all. For the value $schema, be sure you look carefully, I'm pretty sure it must be http://;

@KTrain5169 We allow for fileMatch to be empty array or not defined at all. For the value $schema, be sure you look carefully, I'm pretty sure it must be http://;

thanks for the tips. why does it not support https://?

@KTrain5169 I would recommend reading the JSONSchema specification. There, they define what are valid and not valid values of $schema. We enforce those values so that our schemas work across more implementers, ones that may not be lenient;

@KTrain5169 I would recommend reading the JSONSchema specification. There, they define what are valid and not valid values of $schema. We enforce those values so that our schemas work across more implementers, ones that may not be lenient;

Will do.